Skip to content

numpy 1.12.0 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 32 commits into from
Closed

numpy 1.12.0 #829

wants to merge 32 commits into from

Conversation

mikofski
Copy link
Member

@mikofski mikofski commented Dec 4, 2019

  • Closes adopt NEP-29 #828
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

update numpy to v1.12.0

mikofski added 30 commits May 10, 2019 02:39
* add _to_radians and is_rad to convert only if necessary
* prefix all functions with get_
* add get_f_sky_pv, get_poa_sky_pv, get_ground_angle_tangent,
get_f_gnd_pv, get_f_gnd_pv, get_poa_gnd_pv, etc.
* update API ui

Signed-off-by: Mark Mikofski <[email protected]>
* get_irradiance, output ordered dict or dataframe
* finish updating get_poa_global_bifacial to transpose beam and diffuse
for each side separately
…ion"

- use tan(zenith) in solar projection math latex
- implement gcr_prime and ground-sky-angles calculations
- add stub for ground-diffuse view factor

Signed-off-by: Mark Mikofski <[email protected]>
- calculate ground-sky angles to previous and next rows, assuming height
 is nonzero
- calculate limits on ground where it can see the sky
- calculate the view factor as a function of z on the ground to the sky
- fix places where it still says degrees, bad, no!
- add fixme for pv-sky view factor, still has wrong formula
- add tests for angles from point z on the ground to tops of current
 row, and limits of previous and next rows
- add a script to make the plot of ground-sky view factor versus z
- add comments, change names x->z
- add TODO's to limit number of rows, and set row-type: 'first', 'last',
or 'middle'
- was difference of angles, should be difference of cosines
- also add TODO's to return VF versus point x on panel, and don't use
averages
- change calc_fx_sky to calc_fz_sky since z is for ground and x is for
pv surface
- add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor
* change _bigz() to just return bigz
* create a test figure of integrated vslue
@mikofski mikofski closed this Dec 4, 2019
@mikofski
Copy link
Member Author

replaced by #830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adopt NEP-29
1 participant