-
Notifications
You must be signed in to change notification settings - Fork 1.1k
numpy 1.12.0 #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
numpy 1.12.0 #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add _to_radians and is_rad to convert only if necessary * prefix all functions with get_ * add get_f_sky_pv, get_poa_sky_pv, get_ground_angle_tangent, get_f_gnd_pv, get_f_gnd_pv, get_poa_gnd_pv, etc. * update API ui Signed-off-by: Mark Mikofski <[email protected]>
* get_irradiance, output ordered dict or dataframe * finish updating get_poa_global_bifacial to transpose beam and diffuse for each side separately
…ion" - use tan(zenith) in solar projection math latex - implement gcr_prime and ground-sky-angles calculations - add stub for ground-diffuse view factor Signed-off-by: Mark Mikofski <[email protected]>
- calculate ground-sky angles to previous and next rows, assuming height is nonzero - calculate limits on ground where it can see the sky - calculate the view factor as a function of z on the ground to the sky - fix places where it still says degrees, bad, no! - add fixme for pv-sky view factor, still has wrong formula - add tests for angles from point z on the ground to tops of current row, and limits of previous and next rows - add a script to make the plot of ground-sky view factor versus z
- add comments, change names x->z - add TODO's to limit number of rows, and set row-type: 'first', 'last', or 'middle'
- was difference of angles, should be difference of cosines - also add TODO's to return VF versus point x on panel, and don't use averages
- change calc_fx_sky to calc_fz_sky since z is for ground and x is for pv surface - add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor
* change _bigz() to just return bigz * create a test figure of integrated vslue
replaced by #830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).update numpy to v1.12.0